This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
feat: Add devworkspace-generator to Che release cycle #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svor
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ibuziuk
approved these changes
Jun 23, 2023
nickboldt
reviewed
Jun 28, 2023
nickboldt
reviewed
Jun 28, 2023
nickboldt
reviewed
Jun 28, 2023
nickboldt
reviewed
Jun 28, 2023
nickboldt
suggested changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes requested.
This was referenced Aug 16, 2023
nickboldt
approved these changes
Aug 16, 2023
SDawley
approved these changes
Aug 16, 2023
SDawley
reviewed
Aug 16, 2023
svor
reviewed
Aug 21, 2023
Signed-off-by: Mykhailo Kuznietsov <[email protected]>
ibuziuk
approved these changes
Aug 29, 2023
…o Che release cycle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Che Devworkspace Generator (here Generator) shall be assigned a che version pattern, so that a che-version artifact will be produced on release (to be used in other che projects, that depend on it).
In main branch, current 0.0.1 version will be changed to next "would-be-released" version, similarly to how it is done in plugin registry.
UPDATE:
Created a separate workflow for releasing just the Generator, which could be performed in the first phase of Che release cycle, so that the projects that depend on it could be released in the following phases ASAP. Release tagging of repo will occur in Devfile Registry release workflow
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#22279
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.