Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Language server] Content of language server hover feature is duplicated #10117

Closed
SkorikSergey opened this issue Jun 20, 2018 · 4 comments
Closed
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@SkorikSergey
Copy link
Contributor

SkorikSergey commented Jun 20, 2018

Description

Content of hover feature is duplicated after workspace restarting in next LS:

  • PHP language server.
  • Python language server
  • Camel language server
  • Yaml language server.
  • Golang language server.

For PHP and Python language servers hover content is duplicated on the first start of workspace( PHP - #10065 and Python - #10063.).

Reproduction Steps

  1. Start a workspace with enabled language server from list above.
  2. Open a file and check that a LS initialized.
  3. Check hover content.
  4. Restart the workspace.
  5. Check hover content again.

Addition information:
41470300-e288e438-70b8-11e8-9790-dfc81b053f1c

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. labels Jun 20, 2018
@tsmaeder
Copy link
Contributor

In the constructor of org.eclipse.che.plugin.languageserver.ide.LanguageServerExtension, a listener is hooked up which calls defaultHoverProviderInitializer.initialize() on each workpace startup. That in turn registers our hover provider each time.

@SkorikSergey SkorikSergey changed the title Content of language server hover feature is duplicated [Language server] Content of language server hover feature is duplicated Aug 8, 2018
@ghost ghost added team/ide severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 11, 2018
@ghost
Copy link

ghost commented Aug 11, 2018

Labeled as P1 since it affects language support for all languages.

@slemeur
Copy link
Contributor

slemeur commented Sep 27, 2018

This does impact Java and NodeJS too

@amisevsk
Copy link
Contributor

amisevsk commented Oct 2, 2018

C# as well. In the ps -ax output for the workspace I see

513 ?  S      0:00 /bin/sh /home/user/che/ls-csharp/launch.sh
514 ?  S      0:00 bash /home/user/che/ls-csharp/run -lsp
522 ?  Sl     0:10 /home/user/che/ls-csharp/bin/mono.linux-x86_64 /home/user/che/ls-csharp/omnisharp/OmniSharp.exe -lsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

6 participants