Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Language server] Signature Help feature doesn't work with "(" character #10699

Closed
SkorikSergey opened this issue Aug 8, 2018 · 4 comments
Closed
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@SkorikSergey
Copy link
Contributor

SkorikSergey commented Aug 8, 2018

Reproduction Steps:

  1. Create and start workspace from PHP stack with "web-php-simple" project.
  2. Open index.php file and change text to:
<?php
function sum($x, $y) {
    return $x + $y;
}
echo "14 + 16 = " . sum(14,16)
?>
  1. Create a new line in position 6 and type sum(.

Expected behavior:
Hover with (mixed $x, mixed $y) message appeared.

Observed behavior:
Nothing changes. The feature will work only with "," character.

Che version: 6.10.0
OS and version: Fedora 28
Language servers that supported this feature: PHP, Python, Clang, Type Script, Golang, C#.

Additional information:

  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
  • See the attachment:

Screencast:
screencast-che-eclipse-che 172 19 20 234 nip io-2018 08 08-13-11-02

Screenshot:
Hover will appear only after "," character.
selection_071

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. team/ide severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 8, 2018
@SkorikSergey SkorikSergey changed the title Signature Help feature doesn't work with "(" character [Language server] Signature Help feature doesn't work with "(" character Aug 8, 2018
@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 14, 2018

There is no code in the signature help provider that hard codes any particular trigger character. Most likely, the php language server does not provide "(" as a trigger character. That would be a problem with the PHP language server outside of our control.

@SkorikSergey
Copy link
Contributor Author

selection_126

@musienko-maxim musienko-maxim added severity/P1 Has a major impact to usage or development of the system. sprint/next team/ide and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 21, 2018
@musienko-maxim
Copy link
Contributor

musienko-maxim commented Sep 21, 2018

So, as we've just clarified this feature works as well with Ctrl+P key. And we should implement this in our tests. But this one also is invoked by (( and , symbols. And this may be bring potential conflicts. We have to think how it should work together.
Also after invocation of ( symbol we have unexpected exceptions in the dev-machine console under TypeScript LS. So, we are going to check this under other language servers and report about this in this issue.

  • The unexpected exceptions are actual for TypeScript LS only.

@dkuleshov dkuleshov self-assigned this Oct 16, 2018
@dkuleshov dkuleshov added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 16, 2018
@dkuleshov
Copy link

ci-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

5 participants