Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find All references doesn't exist for typescript plugin #14856

Closed
3 of 23 tasks
AndrienkoAleksandr opened this issue Oct 11, 2019 · 5 comments · Fixed by eclipse-che/che-theia#653
Closed
3 of 23 tasks

Find All references doesn't exist for typescript plugin #14856

AndrienkoAleksandr opened this issue Oct 11, 2019 · 5 comments · Fixed by eclipse-che/che-theia#653
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
Backlog - Languages

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Oct 11, 2019 •
edited
Loading

Describe the bug

Find All references doesn't work for typescript plugin. This feature works fine for VsCode, but doesn't work for che-theia.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Open some typescript file and select some method or class name.
  2. Click right mouse to open context menu.

Expected behavior

In the context menu should be item Find all references like in the VsCode:
Screenshot_20191011_144845

Actual behavior

Find all references is absent.
Screenshot_20191011_144836

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@AndrienkoAleksandr AndrienkoAleksandr added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. area/languages Issues related to Language extensions or plugins integration. team/languages labels Oct 11, 2019
@AndrienkoAleksandr AndrienkoAleksandr changed the title Find All references doesn't work for typescript plugin Find All references doesn't exist for typescript plugin Oct 11, 2019
@AndrienkoAleksandr AndrienkoAleksandr removed the severity/P2 Has a minor but important impact to the usage or development of the system. label Oct 11, 2019
@AndrienkoAleksandr
Copy link
Contributor Author

Hmm... I removed P2, because I see we have feature 'Peek References' which is close to 'Find All references'

@tolusha
Copy link
Contributor

tolusha commented Oct 11, 2019

It is interesting to check if latest version fixes the problem

@tolusha tolusha added the severity/P2 Has a minor but important impact to the usage or development of the system. label Oct 11, 2019
@tsmaeder
Copy link
Contributor

I don't think the out-of-line references view is implemented at all in Theia. We should open an issue over there. But yes, it's a PITA when browsing large lists of references.

@tsmaeder
Copy link
Contributor

And here it is: eclipse-theia/theia#4784.

@tsmaeder
Copy link
Contributor

Note that plugins are added to che-theia inside the docker build of the theia image.

@tsmaeder tsmaeder mentioned this issue Oct 16, 2019
Closed
26 tasks
@tsmaeder tsmaeder mentioned this issue Oct 31, 2019
Closed
25 tasks
@tsmaeder tsmaeder mentioned this issue Nov 21, 2019
Closed
26 tasks
@tsmaeder tsmaeder mentioned this issue Dec 13, 2019
Closed
28 tasks
@tsmaeder tsmaeder mentioned this issue Jan 8, 2020
Closed
35 tasks
@tsmaeder tsmaeder added this to the Backlog - Languages milestone Jan 23, 2020
@tsmaeder tsmaeder mentioned this issue Jan 30, 2020
Closed
36 tasks
@tsmaeder tsmaeder mentioned this issue Feb 18, 2020
Closed
34 tasks
vrubezhny added a commit to vrubezhny/che-theia that referenced this issue Mar 3, 2020
@vrubezhny
Add vscode-references-view plugin to che-theia
ef11d1d 
Referenced issue: eclipse-che/che#14856

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny mentioned this issue Mar 4, 2020
Merged
vrubezhny added a commit to vrubezhny/che-theia that referenced this issue Mar 4, 2020
@vrubezhny
Add vscode-references-view plugin to che-theia
beb3be6 
Referenced issue: eclipse-che/che#14856

Signed-off-by: Victor Rubezhny <[email protected]>
azatsarynnyy added a commit to eclipse-che/che-theia that referenced this issue Mar 4, 2020
@azatsarynnyy
Add vscode-references-view plugin to che-theia (#653)
baaa1e3 
Referenced issue: eclipse-che/che#14856

Signed-off-by: Victor Rubezhny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
Backlog - Languages
Development

Successfully merging a pull request may close this issue.

Add vscode-references-view plugin to che-theia vrubezhny/che-theia
3 participants
@tolusha @AndrienkoAleksandr @tsmaeder