Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute folder path to open it as working dir in terminal #11914

Merged
merged 3 commits into from
Nov 30, 2018

Conversation

vzhukovs
Copy link
Contributor

What does this PR do?

This changes proposal modifies the behavior of Open in Terminal action, so the current directory path pass to terminal options in absolute path form instead of relative as it was before.

Signed-off-by: Vladyslav Zhukovskyi [email protected]

What issues does this PR fix or reference?

#10894

Release Notes

N/A

Docs PR

N/A

@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/ide severity/P1 Has a major impact to usage or development of the system. labels Nov 12, 2018
@vzhukovs vzhukovs self-assigned this Nov 12, 2018
@vzhukovs
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11914
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov vparfonov mentioned this pull request Nov 20, 2018
29 tasks
@vparfonov vparfonov mentioned this pull request Nov 28, 2018
15 tasks
@vzhukovs
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11914
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vzhukovs vzhukovs added this to the 6.15.0 milestone Nov 30, 2018
@vzhukovs vzhukovs merged commit b3da3eb into master Nov 30, 2018
@vzhukovs vzhukovs deleted the che#10894 branch November 30, 2018 13:07
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants