Fix 'Go to line' for 'Git Compare' widget #11962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <[email protected]>
RomanNikitenko
added
status/code-review
|
ci-test |
azatsarynnyy
approved these changes
Nov 15, 2018
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1190/) doesn't show any regression against this Pull Request. |
RomanNikitenko
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When user uses 'Go to line' feature Input Dialog is displayed.
We close dialog and try to set cursor for given position when user enters line number and click 'OK' button. At this step an editor loses focus.
So, I propose to execute setting of given position as deferred command.
It allows to set cursor position when dialog is closed after the browser event loop returns.
What issues does this PR fix or reference?
#11791
Signed-off-by: Roman Nikitenko [email protected]