Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Dockerfile #1682

Merged
1 commit merged into from
Jul 7, 2016
Merged

Optimize Dockerfile #1682

1 commit merged into from
Jul 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 7, 2016

Signed-off-by: Eugene Ivantsov [email protected]

Signed-off-by: Eugene Ivantsov <[email protected]>
@ghost
Copy link
Author

ghost commented Jul 7, 2016

Removed curl and ca-certificates

@ghost ghost merged commit 8383f2c into master Jul 7, 2016
@ghost ghost deleted the alpine_base_image branch July 7, 2016 13:44
@benoitf
Copy link
Contributor

benoitf commented Jul 7, 2016

seems we lost comment instruction on first line from previous PR ?

@l0rd l0rd mentioned this pull request Jul 9, 2016
5 tasks
@juampe
Copy link

juampe commented Jul 10, 2016

¿Optimize? This is literraly a rip of ubuntu docker che flavour.

@TylerJewell
Copy link

It reduces the deault image to run Che by 200MB. The workspace images are still based upon ubuntu.

@juampe
Copy link

juampe commented Jul 10, 2016

Sorry, now I got it

some test

root@rails:/opt/che# docker build -t codenvy/che -f Dockerfile .Sending build context to Docker daemon 53.53 MB
Step 1 : FROM alpine:3.4
 ---> 4e38e38c8ce0
Step 2 : ENV LANG C.UTF-8 JAVA_HOME /usr/lib/jvm/default-jvm/jre PATH ${PATH}:${JAVA_HOME}/bin CHE_HOME /home/user/che
 ---> Using cache
 ---> d61ea4bcd9ec
Step 3 : RUN echo "http://dl-4.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories &&     apk upgrade --update &&     apk add --update docker openjdk8 sudo bash &&     addgroup -S user -g 1000 &&     adduser -S user -h /home/user -s /bin/bash -G root -u 1000 -D &&     adduser user docker &&     adduser user user &&     echo "%root ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers &&     rm -rf /tmp/* /var/cache/apk/*
 ---> Using cache
 ---> a4d3d9547fee
Step 4 : EXPOSE 8000 8080
 ---> Using cache
 ---> f85695eccdb9
Step 5 : USER user
 ---> Using cache
 ---> 7ffccc7b76a6
Step 6 : ADD /assembly/assembly-main/target/eclipse-che-*/eclipse-che-* /home/user/che/
No source files were specified

I supose I must got the che compitation in /assembly/assembly-main/target/eclipse-che-/eclipse-che-

@TylerJewell
Copy link

Yes.

Why build it though? You can just docker pull Codenvy/Che.

@bmicklea bmicklea mentioned this pull request Jul 20, 2016
64 tasks
benoitf added a commit that referenced this pull request Feb 8, 2017
- base scripts : catch error code of action lifecycle and return it
- cha-lib : return error code based on http error code
- display better message when auth is required
- skip graceful mode when repo is mounted

Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT <[email protected]>
benoitf added a commit that referenced this pull request Feb 8, 2017
- base scripts : catch error code of action lifecycle and return it
- cha-lib : return error code based on http error code
- display better message when auth is required
- skip graceful mode when repo is mounted

Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT <[email protected]>
benoitf added a commit that referenced this pull request Feb 11, 2017
- base scripts : catch error code of action lifecycle and return it
- cha-lib : return error code based on http error code
- display better message when auth is required
- skip graceful mode when repo is mounted

Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT <[email protected]>
benoitf added a commit that referenced this pull request Feb 13, 2017
…ipts : catch error code of action lifecycle and return it - cha-lib : return error code based on http error code - display better message when auth is required - skip graceful mode when repo is mounted

Change-Id: I4e89605fd3c42ad6ba02115c32297d16f49b3ffe
Signed-off-by: Florent BENOIT <[email protected]>
benoitf added a commit that referenced this pull request Feb 13, 2017
…ipts : catch error code of action lifecycle and return it - cha-lib : return error code based on http error code - display better message when auth is required - skip graceful mode when repo is mounted

Change-Id: Icc0caeb4db3dc3a1be802de95bb1f1d505f93b40
Signed-off-by: Florent BENOIT <[email protected]>
benoitf added a commit that referenced this pull request Feb 13, 2017
* Fix #1682 : Improve UX of graceful shutdown message
- base scripts : catch error code of action lifecycle and return it
- cha-lib : return error code based on http error code
- display better message when auth is required
- skip graceful mode when repo is mounted

Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT <[email protected]>
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* Fix eclipse-che#1682 : Improve UX of graceful shutdown message
- base scripts : catch error code of action lifecycle and return it
- cha-lib : return error code based on http error code
- display better message when auth is required
- skip graceful mode when repo is mounted

Change-Id: I1ad021426444b5b4d880df518512e53ef4828336
Signed-off-by: Florent BENOIT <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants