Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Id selector for the navigator collapse all button instead of css selector #17982

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Use Id selector for the navigator collapse all button instead of css selector #17982

merged 1 commit into from
Sep 29, 2020

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Substitute the css selector of the navigator collapse all button with id selector in the ProjectTree selenium tests page object.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che-theia#857

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 29, 2020
@che-bot
Copy link
Contributor

che-bot commented Sep 29, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@vinokurig vinokurig changed the title Use Id selector for the navigator collapse all button instead of css selector [WIP] Use Id selector for the navigator collapse all button instead of css selector Sep 29, 2020
@vinokurig vinokurig closed this Sep 29, 2020
@vinokurig vinokurig deleted the che-16041 branch September 29, 2020 08:13
@vinokurig vinokurig restored the che-16041 branch September 29, 2020 08:42
@vinokurig vinokurig reopened this Sep 29, 2020
@che-bot
Copy link
Contributor

che-bot commented Sep 29, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@vinokurig vinokurig changed the title [WIP] Use Id selector for the navigator collapse all button instead of css selector Use Id selector for the navigator collapse all button instead of css selector Sep 29, 2020
dmytro-ndp
dmytro-ndp approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, but, please, merge it at evening after eclipse-che/che-theia#857 has been merged so that it would not affect PR check during the day.

@che-bot
Copy link
Contributor

che-bot commented Sep 29, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@vinokurig
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 29, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@vinokurig
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 29, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@vinokurig vinokurig merged commit ae0d569 into master Sep 29, 2020
@vinokurig vinokurig deleted the che-16041 branch September 29, 2020 19:35
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 29, 2020
@che-bot che-bot added this to the 7.20 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@rhopp rhopp Awaiting requested review from rhopp

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@SkorikSergey SkorikSergey Awaiting requested review from SkorikSergey

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.20
Development

Successfully merging this pull request may close these issues.
3 participants
@vinokurig @che-bot @dmytro-ndp