-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-3609: Create visual Git history window instead of old one #3799
Conversation
@@ -98,6 +101,25 @@ public final void writeTo(OutputStream out) throws IOException { | |||
} | |||
} | |||
|
|||
private List<DiffEntry> EmptyToCommit(String commitId, DiffFormatter formatter) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmptyToCommit
method name should starts with lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -98,6 +101,25 @@ public final void writeTo(OutputStream out) throws IOException { | |||
} | |||
} | |||
|
|||
private List<DiffEntry> EmptyToCommit(String commitId, DiffFormatter formatter) throws IOException { | |||
ObjectId commit = repository.resolve(commitId); | |||
if (commit == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, guava has utility method com.google.common.base.Preconditions#checkArgument(boolean, java.lang.Object)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
service.diff(appContext.getDevMachine(), project.getLocation(), filePatterns, RAW, false, 0, revision.getId(), isCached) | ||
.then(new Operation<String>() { | ||
private void FetchRevisions() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method name should starts with lowercase letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -46,6 +45,7 @@ | |||
@Singleton | |||
public class ResetToCommitPresenter implements ResetToCommitView.ActionDelegate { | |||
public static final String RESET_COMMAND_NAME = "Git reset to commit"; | |||
public static final String LOG_COMMAND_NAME = "Git log"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Other seems ok |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1680/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1685/ |
What does this PR do?
Add new visual Git history window instead of old one.
What issues does this PR fix or reference?
#3609
Changelog
Git history panel changed to a window to enable visualization of commit changes.
Release Notes
We've replaced the git history panel with a new window. This allows you to see the changes from each commit visually with a diff viewer. You can get to the git history from the git menu, or you can right-click on a file in the project explorer and select git history from the context menu.
The git history window will show you all the commits:
Double clicking on a revision item, or clicking the 'Compare' button will open the visual diff viewer:
Tests written?
Yes