Implement new format workspace key {namespace}/{workspaceName} or {workspaceId} #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
ashumilova,
vparfonov,
skabashnyuk and
voievodin
sleshchenko
force-pushed
the
compositeNamespace
branch
from
907a914
to
4659ec7
Compare
sleshchenko
changed the title
slemeur
added
the
kind/task
voievodin
approved these changes
Feb 9, 2017
sleshchenko
force-pushed
the
compositeNamespace
branch
from
e2c2911
to
0929620
Compare
ashumilova
approved these changes
Feb 9, 2017
vparfonov
approved these changes
Feb 9, 2017
skabashnyuk
approved these changes
Feb 9, 2017
slemeur
approved these changes
Feb 9, 2017
sleshchenko
force-pushed
the
compositeNamespace
branch
from
0929620
to
b1393fb
Compare
added 3 commits
February 10, 2017 15:04
…in `/` symbols
Impemented new format workspace key:
1. {workspaceId}
2. {namespace}/{workspaceName}
Note that namespace can contains '/' symbol so workspace key can looks like {namespace_part1}/{namespace_part2}/.../{namespace_partN}/{workspaceName}.
According to new workspace key format changes URL
to IDE looks like {HOST}/namespace/namespace_part_2/workspaceName
According to new workspace key format changes URL to
dashboard workspace details team looks like
{HOST}/dashboard/#/workspace/namespace/namespace_part_2/workspaceName
sleshchenko
force-pushed
the
compositeNamespace
branch
from
f915990
to
2732c33
Compare
|
Build # 1937 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1937/ to view the results. |
|
What about cli changes ? |
|
PR for CLI : #4115 |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…rkspaceId} (eclipse-che#4073) * CHE-4061 Rework workspace key to new format where namespace can contain `/` symbols Impemented new format workspace key: 1. {workspaceId} 2. {namespace}/{workspaceName} Note that namespace can contains '/' symbol so workspace key can looks like {namespace_part1}/{namespace_part2}/.../{namespace_partN}/{workspaceName}. * CHE-4061 Adapt IDE to work with workspace key in new format According to new workspace key format changes URL to IDE looks like {HOST}/namespace/namespace_part_2/workspaceName * CHE-4061 Adapt dashboard to work with workspace key in new format According to new workspace key format changes URL to dashboard workspace details team looks like {HOST}/dashboard/#/workspace/namespace/namespace_part_2/workspaceName
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
…rkspaceId} (#4073) * CHE-4061 Rework workspace key to new format where namespace can contain `/` symbols Impemented new format workspace key: 1. {workspaceId} 2. {namespace}/{workspaceName} Note that namespace can contains '/' symbol so workspace key can looks like {namespace_part1}/{namespace_part2}/.../{namespace_partN}/{workspaceName}. * CHE-4061 Adapt IDE to work with workspace key in new format According to new workspace key format changes URL to IDE looks like {HOST}/namespace/namespace_part_2/workspaceName * CHE-4061 Adapt dashboard to work with workspace key in new format According to new workspace key format changes URL to dashboard workspace details team looks like {HOST}/dashboard/#/workspace/namespace/namespace_part_2/workspaceName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement new format workspace key:
Note that namespace can contain '/' symbol so workspace key can look like {namespace_part1}/{namespace_part2}/.../{namespace_partN}/{workspaceName}.
Also this PR contains required changes for IDE and Dashboard.
What issues does this PR fix or reference?
#4061
Changelog
Reworked workspace key to new format where namespace can contain
/symbols.Release Notes
Reworked workspace key to new format where namespace can contain
/symbols.Docs PR
Will be explained as part of the documentation for teams.