Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory bug in contrib/ecalhdf5/src/eh5_meas_dir.cpp #153

Closed
ZobyTwo opened this issue Jan 5, 2021 · 1 comment
Closed

Memory bug in contrib/ecalhdf5/src/eh5_meas_dir.cpp #153

ZobyTwo opened this issue Jan 5, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ZobyTwo
Copy link

ZobyTwo commented Jan 5, 2021 •
edited
Loading

Hey there,

in contrib/ecalhdf5/src/eh5_meas_dir.cpp, in the second ctor (line 52), you should set access_ (to RDONLY) so that the nested call to Close() does not read from uninitialized memory.
@FlorianReimold
Copy link
Member

Hey, thanks for pointing that out! I will check (and fix) that!

@FlorianReimold FlorianReimold added the bug Something isn't working label Jan 12, 2021
FlorianReimold added a commit that referenced this issue Feb 18, 2021
@FlorianReimold
Fixed uninitialized variable (#153)
2df0e57
FlorianReimold added a commit that referenced this issue Feb 18, 2021
@FlorianReimold
Fixed uninitialized variable (#153)
171a76b
FlorianReimold added a commit that referenced this issue Feb 18, 2021
@FlorianReimold
Fixed uninitialized variable (#153)
5b60307
FlorianReimold added a commit that referenced this issue Feb 18, 2021
@FlorianReimold
Fixed uninitialized variable (#153)
b66bd23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZobyTwo @FlorianReimold