Minor refactoring to keep eCAL::hdf5 like it was before hdf5 restructuring #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically we revert
eCAL::hdf5to the way it was before the first work to integrate mcap.Instead we introduce one layer of indirection.
eCAL::measurement::base::Writer/Reader(CMake: eCAL::measurement_base) -> new class (atm pure virtual), which will serve as the new Interface, for all users, and will evolve until the next release.eCAL::measurement::hdf5::Writer/Reader(CMake: eCAL::measurement_hdf5) -> concrete hdf5 implementation, which (under the hood) uses the "old" hdf5 implementation (CMake: eCAL::hdf5)Atm, this is more or less a pure pimpl, however, as the
Reader/Writerinterface will evolve over time, the original interface will stay the same.The high level measurement interface was moved from
eCAL::hdf5toeCAL::measurement_base.Related issues
Related to #1076
Cherry-pick to