Fix segfault in GetCpuCores #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The branch reading line 12 of /proc/cpuinfo is valid only for __x86_64__
|
What is with x86 (-> 32 bit)? And what will happen for non intel/amd platforms like arm? Wouldn't it be a better idea to use Edit: According to some stackoverflow answer, this should be a rather portable solution: Here is the |
which is simpler and more generic.
|
I agree that |
FlorianReimold
approved these changes
Nov 7, 2023
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Use get_nprocs() to read the number of cores which is simpler and more generic.
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Use get_nprocs() to read the number of cores which is simpler and more generic.
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Use get_nprocs() to read the number of cores which is simpler and more generic.
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Use get_nprocs() to read the number of cores which is simpler and more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The branch reading line 12 of /proc/cpuinfo is valid only for
__x86_64__.So, bugfix is to restrict this branch for
__x86_64__only.Or, simpler and more generic, use
get_ncores().Related issues
Cherry-pick to