cleanup udp configuration and sender/receiver attributes #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l setting GetPayloadMulticastAddress (former GetTopicMulticastAddress) returns LocalHost in case of local network mode and GetUdpMulticastGroup if no topic_name is empty
new function eCAL::UDP::LocalBroadcastAddress() for later logic cleanups
KerstinKeller
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for a new udp communication layer implementation there are some cleanups made in udp_confiuration and the sender and receiver udp attribute structures. Test under Windows and Ubuntu with local and network mode and for Windows with and without npcap.
Related issues
Is not fixing any issue, should behave as before.
Cherry-pick to