[Python/clang] Add missing core functions #1300
Conversation
Is this caused by the PR? |
|
The error that you posted is a Sphinx version missmatch, which is documentation related. We use Sphinx to build the documentation. |
|
@DownerCase We have this problem on all GH action builds atm (#1301), will try to solve ASAP and then rebuild the PR. Thanks for your contribution anyways. |
DownerCase
force-pushed
the
python_add_core_functions
branch
from
51ca1f0
to
e56ceed
Compare
Thanks, looks like you solved it! |
* Doc: Downgraded sphinx related packages in requirements.txt (#1302) * The most recent release of various sphinx related packages need Sphinx 5 or up, but our old sphinx-book-theme 0.3.3 requires Sphinx 4 For a proper solution see #1303 * CMake: Fixed Findqwt.cmake (#1306) * [Python/clang] Add missing core functions (#1300) Adds the missing core functions from ecal_core.h (GetVersion, IsInitialized, SetUnitName) to ecal_clang and the python wrapper. * Measurement API: Introduce experimental namespace to mark new api as not yet stable. (#1307) --------- Co-authored-by: Florian Reimold <[email protected]> Co-authored-by: DownerCase <[email protected]>
|
@DownerCase, could you please sign the ECA even though we already merged the commit to master? |
|
@KerstinKeller Sorry! Should be good now! The validation tool is shows it as accepted now 😄 |
Description
Adds the missing core functions from ecal_core.h (GetVersion, IsInitialized, SetUnitName) to ecal_clang and the python wrapper.
I had to implement the non-string version of GetVersion as
getversion_componentsdue to the obvious name already being taken.Tested locally and all works perfectly.
Tangents:
ecal_clangandecal/cimpl)mon_pubmonitoringandmon_publoggingneed reimplementing for v5.13 due to the partial API removal.Related issues
Closes #1239
Cherry-pick to