[Core] Remove unnecessary new operators ...

[KerstinKeller]

and replace with make_shared or make_unique.

Description

There is really need for explicit use of new so replace with creation of shared/unique pointers.

Cherry-pick to:

• None (changes public API slightly and will therefore be ABI compatible)

[github-actions]

clang-tidy made some suggestions

[github-actions]

warning: method 'IsCreated' can be made const [readability-make-member-function-const]

Suggested change

	ECAL_API bool IsCreated() { return(created); }
	ECAL_API bool IsCreated() const { return(created); }

[github-actions]

clang-tidy made some suggestions

[github-actions]

warning: move assignment operators should be marked noexcept [performance-noexcept-move-constructor]

Suggested change

	ECAL_API CTimer& operator=(CTimer&& rhs);
	ECAL_API CTimer& operator=(CTimer&& rhs) noexcept ;

[github-actions]

warning: move assignment operators should be marked noexcept [performance-noexcept-move-constructor]

Suggested change

	ECAL_API CDynamicJSONSubscriber& operator=(CDynamicJSONSubscriber&& rhs);
	ECAL_API CDynamicJSONSubscriber& operator=(CDynamicJSONSubscriber&& rhs) noexcept ;

[github-actions]

warning: move assignment operators should be marked noexcept [performance-noexcept-move-constructor]

ecal/core/src/pubsub/ecal_proto_dyn_json_sub.cpp:215:

-       = default;
+  noexcept       = default;

[KerstinKeller]

We should rather delete the move operator than to just default them, it might lead to problems.

[KerstinKeller]

Ubuntu build fails with:

5: Test command: /home/runner/work/ecal/_build/bin/ecal_test_core-5.13.0
5: Working Directory: /home/runner/work/ecal/_build/bin
5: Test timeout computed to be: 10000000
5: Running main() from /home/runner/work/ecal/ecal/thirdparty/gtest/googletest/googletest/src/gtest_main.cc
5: [==========] Running 3 tests from 1 test suite.
5: [----------] Global test environment set-up.
5: [----------] 3 tests from Core
5: [ RUN      ] Core.MultipleInitializeFinalize
5: [       OK ] Core.MultipleInitializeFinalize (7006 ms)
5: [ RUN      ] Core.LeakedPubSub
5: [       OK ] Core.LeakedPubSub (5004 ms)
5: [ RUN      ] Core.CallbackDestruction
5: double free or corruption (out)
 5/14 Test  #5: test_core ........................Subprocess aborted***Exception:  16.16 sec

Need to check if sporadic failure (even though - why?) or reproducible from the changes (though I wouldn't know / understand why...).