Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependencies] Add Protobuf 3.26 support to eCAL. (#1530) #1535

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

KerstinKeller
Copy link
Contributor

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

DescriptorErrorCollector() {}
~DescriptorErrorCollector() {}
DescriptorErrorCollector() = default;
~DescriptorErrorCollector() override {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use '= default' to define a trivial destructor [modernize-use-equals-default]

Suggested change
~DescriptorErrorCollector() override {}
~DescriptorErrorCollector() override = default;

@KerstinKeller KerstinKeller added the Auto Approve Request Automatic PR Approval label Apr 16, 2024
@KerstinKeller KerstinKeller merged commit 05c9cfc into support/v5.12 Apr 16, 2024
11 checks passed
@KerstinKeller KerstinKeller deleted the feature/5-12-protobuf-3-26 branch April 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto Approve Request Automatic PR Approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant