[Core / Service]: Fixed crash that occured when communicating with eCAL 5.12 services #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AL 5.12 services The crash occured when a v0 client connected to a service server.
FlorianReimold
added
the
cherry-pick-to-support/v5.13
KerstinKeller
approved these changes
May 2, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1605,6 +1605,151 @@ TEST(ecal_service, Callback_SerializedServiceCallbacks) // NOLINT | |||
| } | |||
| #endif | |||
|
|
|||
| #if 1 | |||
| // Call different eCAL Service API functions from within the callbacks | |||
| TEST(ecal_service, Callback_ApiCallsFromCallbacks) | |||
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(ecal_service, Callback_ApiCallsFromCallbacks) | |
| TEST(ecal_service /*unused*/, Callback_ApiCallsFromCallbacks /*unused*/) |
|
ServerSessionV0::Start() is called by the factory create. As the buggy v0 protocol completely lacks any connection establishment, it immediately assumes that it is connected and therefore calls the EventCallback with a connected event. Before, it did that in the same thread. Now it does that in the io_context thread. v1 never had that issue, as the EventCallback is called after the connection has been established. Thus, the event callback has always been called from the io_context thread. |
FlorianReimold
added a commit
that referenced
this pull request
May 3, 2024
…AL 5.12 services (#1579) The crash occured when a v0 client connected to a service server.
FlorianReimold
added a commit
that referenced
this pull request
May 3, 2024
…AL 5.12 services (#1579) The crash occured when a v0 client connected to a service server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The crash occured when a v0 client connected to a service server.
Related issues