Use "modification time" instead of "creation time" on Windows #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank's for the PR! I will take a look, but it may take me some time. Please be patient ;-) |
|
Short status update: Yes, this was a bug, thanks for reporting and fixing. The bug however must be fixed for Non-Windows platforms as well. |
monsieurgustav
force-pushed
the
master
branch
from
d5c5159
to
02734ce
Compare
|
Yes, I only work on Windows ATM and I generally don't make change I cannot test... |
|
I will test it out on other plattforms as well and then and merge it! I am not sure, but I think that also returning the localtime is not entirely correct. I think, fineftp should use the UTC here, as the client has no way of knowing the local timezone. |
FlorianReimold
changed the base branch from
master
to
hotfix/modification_time
FlorianReimold
merged commit d2b0a45
into
eclipse-ecal:hotfix/modification_time
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.