Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] fix #1596 Major performance issue in case of many new entities (#1843) - backport from master #1863

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

rfelcman
Copy link
Contributor

  • Issue 1596: use a hash-based collection to lookup objects in the cache instead of a linear search
  • Adjusted source according to review:
  • extended tests
  • updated copyright year
  • call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges
  • remove list from primaryKeyToNewObjects if it is empty
  • simplify tests

(cherry picked from commit 76d8274)

…ities (eclipse-ee4j#1843)

* Issue 1596: use a hash-based collection to lookup objects in the cache instead of a linear search
* Adjusted source according to review:
- extended tests
- updated copyright year
- call removeObjectFromPrimaryKeyToNewObjects in preMergeChanges
- remove list from primaryKeyToNewObjects if it is empty
- simplify tests

Signed-off-by: Patrick Schmitt <[email protected]>

(cherry picked from commit 76d8274)
Signed-off-by: Radek Felcman <[email protected]>
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit edb84b9 into eclipse-ee4j:3.0 Apr 17, 2023
@rfelcman rfelcman deleted the new_entities_performance_3.0 branch April 17, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants