[2.7] fix 1957: Presize HashMap allocations in UnitOfWorkImpl - backport from master #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add initial size to map creation where expected size is known or can be estimated Signed-off-by: Patrick Schmitt <[email protected]>
|
@rfelcman I am unsure how to deal with the test failure. |
rfelcman
approved these changes
Oct 11, 2023
rfelcman
added a commit
that referenced
this pull request
Oct 11, 2023
It seems, that code change introduced in #1959 doesn't work correctly on JDK 11 (17 and 21 works). It's about following line Map visitedObjects = new IdentityHashMap(values.stream().collect(Collectors.summingInt(Set::size))); Issue is presented by following EL test error: NestedUnitOfWorkDeleteNestedNewObjectTest Exception Description: Fatal error occurred. Internal Exception: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.util.Map (java.lang.Integer and java.util.Map are in module java.base of loader 'bootstrap') Local Exception Stack: Exception [EclipseLink-0] (Eclipse Persistence Services - 2.7.14.qualifier): org.eclipse.persistence.testing.framework.TestErrorException Exception Description: Fatal error occurred. Internal Exception: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.util.Map (java.lang.Integer and java.util.Map are in module java.base of loader 'bootstrap') at org.eclipse.persistence.testing.framework.TestCase.execute(TestCase.java:168) at org.eclipse.persistence.testing.framework.TestCase.runBare(TestCase.java:267) at org.eclipse.persistence.testing.framework.TestExecutor.execute(TestExecutor.java:250) at org.eclipse.persistence.testing.framework.TestSuite.execute(TestSuite.java:82) at org.eclipse.persistence.testing.framework.TestCollection.run(TestCollection.java:315) at org.eclipse.persistence.testing.framework.TestExecutor.execute(TestExecutor.java:250) at org.eclipse.persistence.testing.framework.TestModel.execute(TestModel.java:213) at org.eclipse.persistence.testing.framework.TestCollection.run(TestCollection.java:315) at org.eclipse.persistence.testing.framework.TestExecutor.execute(TestExecutor.java:250) at org.eclipse.persistence.testing.framework.TestModel.execute(TestModel.java:213) at org.eclipse.persistence.testing.framework.TestCollection.run(TestCollection.java:315) Caused by: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.util.Map (java.lang.Integer and java.util.Map are in module java.base of loader 'bootstrap') at org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.calculateChanges(UnitOfWorkImpl.java:812) at org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commitNestedUnitOfWork(UnitOfWorkImpl.java:1389) at org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.commit(UnitOfWorkImpl.java:1184) at org.eclipse.persistence.testing.tests.unitofwork.NestedUnitOfWorkDeleteNestedNewObjectTest.test(NestedUnitOfWorkDeleteNestedNewObjectTest.java:44) at org.eclipse.persistence.testing.framework.TestCase.executeTest(TestCase.java:547) at org.eclipse.persistence.testing.framework.TestCase.execute(TestCase.java:158) it happens only if product (EclipseLink) is build by JDK 11. Test itself should be called with any JDK (11, 17, 21). Origin lambda is refactored into more "classical" style. Signed-off-by: Radek Felcman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1958