Fix the sigtest Release to allow for new JVM's #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ository. Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
sig-generation-fix
branch
from
fd20806
to
cf18a0e
Compare
…uire a minimum of Java SE 17 for testing and add Java 17 tests. Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
sig-generation-fix
branch
from
cf18a0e
to
b28ae26
Compare
scottmarlow
approved these changes
Feb 14, 2024
|
I built the change locally and verified that the EE 10 Platform TCK signature tests still work correctly with this change on Java SE 11/17/21. |
starksm64
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of only using data from the version this project was compiled on does not work when you want to run against newer JVM's. For example errors like
Fatal error: class java.lang.annotation.Annotation not foundare reported because thecom.sun.tdk.signaturetest.classpath.Releasecannot be found.This change uses the local
${java.home}/lib/ct.symto determine the signature files.resolves #22