-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (un)marshal bug #1135 #1294
Conversation
Issue tracker reference: |
@eclipsewebmaster I have signed ECA, how to refresh the |
Can someone check this please ? |
This fix causes a regression where in the class is abstract and has subclasses along with a IDREF defined in it. With the new fix, While validating the generated xml against the schema it gives the following Exception.
It doesnt check the IDREF in the isLeaf() method of The reproducer project where the We get a wrong xml with IDREF type treated as a discrete type without any connection to ID. Expected xml
Actual xml
I think this fix needs restructuring or additional checks. |
@gaol Can you please comment on my previous update? |
@loser168 Hi, I am very sorry that the message was drowned that I did not notice. The PR comes from the old repository by another guy. So I need to investigate it before I can give any comments :) I am currently working on another issue, and I hope I can be back to this issue this week. :) Thanks again. :) |
Thanks @gaol. Will wait for your inputs :) |
@loser168 Hi, I just updated the PR by moving the subclass checks down after IDREF checks. It passed tests in my local environment(JDK11), and it passed the regression you found as well. Would you please confirm? Thank you very much! |
@loser168 I also included your regression tests into the PR, would you please review? Can anyone move this issue on? Thanks. |
Can anyone review? This is just one line change, and it has been pending for several months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new files are missing license headers
Original PR: javaee/jaxb-v2#1155 Move the original fix down after IDREF check Signed-off-by: Lin Gao <[email protected]>
Refer to: https://github.com/NiasSt90/jaxb-bug1135 Signed-off-by: Lin Gao <[email protected]>
@lukasj Thank you for the review, I added the missing license headers to the new files. Would you please review again? Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just for the record new files created in 2019 should say just 2019 and not 1997.
Fix Issue: #1135
Original PR from: javaee/jaxb-v2#1155
Signed-off-by: Lin Gao [email protected]