Put Parameter class in core-common, to be used by both client and server #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a proposal of how it would be possible to move the logic of Parameter to Core-Common. There is not a good solution, as Parameter ought to stay in core-server, as it is part of the public API. Since most methods are static and static methods are not virtual, it is hard to make the inheritance work. The options are as follows:
|
… server Signed-off-by: Jan Supol <[email protected]>
Signed-off-by: Jan Supol <[email protected]>
senivam
approved these changes
Apr 8, 2019
…in the list Signed-off-by: Jan Supol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Supol [email protected]