-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Various bugs in Helloworld CDI SE Example #4206
Conversation
@eclipsewebmaster @eclipse-ece-validation The Eclipse FDN / ECA validation fails to connect its internal database. Can you please fix this? Thanks! :-) |
it's because commit's header is validated vs author's email (
|
@senivam Thank you for inspecting this, I will fix the author line ASAP. Anyways, this does not explain why the ECA check fails to connect to Eclipse Foundation's MariaDB... |
(1) README.MD - Sample link misses mandatory parameter (2) pom.xml - Surplus prefix for main class (3) App.java - Surplus base path for root url Signed-off-by: Markus KARG <[email protected]>
@senivam Fixed the ECA check, but Travis failed with connect problems under your user while the same build works with my user. Can you please press "Retry" in Travis CI for the failing build so this PR passes the final check? Thanks! :-) |
@senivam Thanks! :-) |
All checks passed. Requesting merge. :-) |
@mkarg you are welcome :) it's obvious that you would like to have it merged, or why to submit PR at all? :) And for sure after review there is a possibility that it will be merged though... |
@senivam Wasn't intended to stress you; just wanted to inform that the troubles we had with this PR are finally passed, nothing more. :-) |
...es/helloworld-cdi2-se/src/main/java/org/glassfish/jersey/examples/helloworld/cdi2se/App.java
Show resolved
Hide resolved
Signed-off-by: Markus KARG <[email protected]>
63a310d
to
c87b849
Compare
Signed-off-by: Markus KARG <[email protected]>
@senivam Changed as requested. Travis succeeded in my fork, but failed in origin. I think it will pass if you restart the two failing jobs. It seems Travis is rathe runstable these days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jansupol @arjantijms Requesting 2nd review. 🙏 |
@arjantijms Thanks a lot! 🎉 |
This PR fixes various bugs of the Helloworld CDI SE example.