FISH-5890 Upgrade MicroProfile Rest Client to 3.0 #4946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <[email protected]>
|
The actual branch, 3.1 already contains the upgrade to MP Client 3.0. |
|
Jersey 3.1.0-M1 in staging contains the implementation https://jakarta.oss.sonatype.org/content/groups/staging/org/glassfish/jersey/ext/microprofile/jersey-mp-rest-client/3.1.0-M1/ |
jansupol
reviewed
Dec 22, 2021
| @@ -110,7 +109,7 @@ | |||
| <configuration> | |||
| <instructions> | |||
| <Export-Package> | |||
| org.glassfish.jersey.restclient.*;version=${project.version} | |||
| org.glassfish.jersey.microprofile.restclient.*;version=${project.version} | |||
There was a problem hiding this comment.
We have this wrong in 3.1, I assume
There was a problem hiding this comment.
We are planning 3.1.0-M2 this week, we should fix it there.
jansupol
reviewed
Dec 22, 2021
| @@ -2081,7 +2081,8 @@ | |||
|
|
|||
| <bouncycastle.version>1.68</bouncycastle.version> | |||
| <commons-lang3.version>3.3.2</commons-lang3.version> | |||
| <microprofile.config.version>2.0</microprofile.config.version> | |||
| <microprofile.config.version>3.0.1</microprofile.config.version> | |||
There was a problem hiding this comment.
We probably should not update the config version to 3.x, there is no implementation for it out there, yet.
|
Thanks @jansupol , As 3.1 branch already have this upgrade, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gupta [email protected]