Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on servlet-api updated to version 6, grizzly to 4 #5009

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Mar 18, 2022

Depends on Grizzly snapshot, that is why it is just a draft.

@dmatej dmatej changed the title Depepndency on servlet-api updated to version 6.0.0 Depepndency on servlet-api updated to version 6, grizzly to 4 Mar 18, 2022
@jansupol
Copy link
Contributor

I wonder whether you can drop the Servlet 5 dependencies for the Jetty tests.

@dmatej
Copy link
Contributor Author

dmatej commented Mar 18, 2022

I wonder whether you can drop the Servlet 5 dependencies for the Jetty tests.

I had the same question, but as the build uses just the server as it is and uses jetty client, both 11.0.7, it passed all tests to my surprise. But I still need to rerun everything once more, now I'm back on Glassfish using this branch as in GF's branch I enabled some tests and 2 of them which failed, which caused this avalanche of updates.

Jersey tests did not pass with servlet5, when I updated just grizzly dependency.

@jansupol jansupol linked an issue Mar 24, 2022 that may be closed by this pull request
@dmatej dmatej marked this pull request as ready for review March 28, 2022 11:13
@dmatej dmatej changed the title Depepndency on servlet-api updated to version 6, grizzly to 4 Dependency on servlet-api updated to version 6, grizzly to 4 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete the upgrade to servlet6 and grizzly4
4 participants