-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release MessageBodyWorkers when Response gets closed. #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user framework holds Response, but the it is closed, the MessageBodyWorkers references the injectionManager. The MessageBodyWorkers is no longer required for a closed message, but the GC cannot release the MBW. The PR tries to prevent OOME when the user closes the Response. |
Signed-off-by: jansupol <[email protected]>
senivam
approved these changes
Apr 20, 2022
jbescos
approved these changes
Apr 21, 2022
Signed-off-by: jansupol <[email protected]>
…cally Signed-off-by: jansupol <[email protected]>
jbescos
approved these changes
Apr 22, 2022
senivam
approved these changes
Apr 25, 2022
This was referenced Jun 14, 2022
Closed
This was referenced Dec 7, 2022
Closed
1 task
This was referenced Jan 6, 2023
Merged
This was referenced Feb 11, 2023
Closed
1 task
This was referenced May 11, 2023
This was referenced Jun 1, 2023
This was referenced Jun 4, 2023
This was referenced Jun 15, 2023
This was referenced Jul 6, 2023
This was referenced Aug 28, 2023
This was referenced Jan 16, 2024
1 task
1 task
This was referenced Apr 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jansupol [email protected]