Fix thread leak/invasion #5589
Merged
Fix thread leak/invasion #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jersey/Jetty, at least in the 3.1 version line, creates one thread for each HTTP request. This behavior was introduced with eclipse-ee4j#5372 and seems not present in the 2.x or 3.x versions of Jersey. From the javadoc of `java.util.Timer`: ``` Implementation note: All constructors start a timer thread. ... After the last live reference to a Timer object goes away and all outstanding tasks have completed execution, the timer's task execution thread terminates gracefully (and becomes subject to garbage collection). However, this can take arbitrarily long to occur. ``` It is fair to assume that "arbitrarily long" may also mean _never_, in case GC never runs. This change replaces the timer & thread per request with a `ScheduledExecutorService` instance per `JettyHttpContainer`. Also changed the set-timeout mechanism to use `System.nanoTime()` instead of `System.currentTimeMillis()`, because the latter is prone to wall-clock drift and can result into wrong timeout values. Fixes eclipse-ee4j#5588 Signed-off-by: Robert Stupp <[email protected]>
senivam
approved these changes
Apr 4, 2024
|
@senivam is this going to land in the next 3.1.x release? |
jansupol
approved these changes
Apr 4, 2024
|
@wendigo, it's heading there |
This was referenced Apr 5, 2024
1 task
This was referenced Apr 6, 2024
This was referenced Apr 10, 2024
1 task
1 task
1 task
This was referenced Jul 9, 2024
1 task
This was referenced Jul 28, 2024
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jersey/Jetty, at least in the 3.1 version line, creates one thread for each HTTP request. This behavior was introduced with #5372 and seems not present in the 2.x or 3.x versions of Jersey.
From the javadoc of
java.util.Timer:It is fair to assume that "arbitrarily long" may also mean never, in case GC never runs.
This change replaces the timer & thread per request with a
ScheduledExecutorServiceinstance perJettyHttpContainer.Also changed the set-timeout mechanism to use
System.nanoTime()instead ofSystem.currentTimeMillis(), because the latter is prone to wall-clock drift and can result into wrong timeout values.Fixes #5588