-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micrometer - Add missing metrics for cases of client errors #5592
Conversation
d67dc74
to
9bf5b5d
Compare
Thank you for the PR. Will the #5531 be fixed either? |
No problem! #5531 is a different issue. |
Changes ported from micrometer-metrics: micrometer-metrics/micrometer#4326
9bf5b5d
to
854305b
Compare
yes, I'm just reminding in order not to forget about it :) |
Any chance for this fix to be ported to the 3.x version as well? We are actually seeing NullPointerExceptions caused by matchingPattern being null when making a request to a non-existing URL. |
@andersflemmen it should already be there, all fixes in the 2.x are later uptaken by 3.0, 3.1 etc. |
Sorry, the error actually occurs in the JerseyKeyValues class. Seems like that one had a similar fix in the micrometer repo:
|
@andersflemmen I have it backported in #5690 |
Changes ported from micrometer-metrics/micrometer#4326