Improve file last modified time detection #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arjantijms, please review. |
dmatej
reviewed
Oct 2, 2023
avpinchuk
force-pushed
the
fix-last-modified-detection
branch
2 times, most recently
from
9ed510f
to
fa681f9
Compare
joakime
reviewed
Oct 2, 2023
Signed-off-by: Alexander Pinčuk <[email protected]>
avpinchuk
force-pushed
the
fix-last-modified-detection
branch
from
fa681f9
to
d37cdd3
Compare
|
@joakime, thank you for very detailed explanation! |
dmatej
approved these changes
Oct 3, 2023
arjantijms
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms when file copied,
creationTimeattribute of a target file may be updated with current time whereaslastModifiedTimeattribute of a target file are copying from a source file.This may leads to issue, when
lastModifiedTimeattribute of a new class file less thanlastModifiedTimeattribute of an old class file, and new class would not be loaded.Signed-off-by: Alexander Pinčuk [email protected]