Fix validation after reload #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the validation would not return correct ids after a reload. To fix this the validator needed to be updated. A fix for the modelserver was opened, this is a workaround for now. This can removed again, once we updated to the modelserver version containing the fix. Modelserver change for reference: eclipse-emfcloud/emfcloud-modelserver#244
|
@sgraband is this workaround still needed as the modelserver fix was merged? |
|
No, sorry i should have documented this. I will close this PR as soon #457 is merged, as it consumes the modelserver fix. |
|
Closed via #457! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the validation would not return correct ids after a reload.
To fix this the validator needed to be updated.
A fix for the modelserver was opened, this is a workaround for now.
This can removed again, once we updated to the modelserver version
containing the fix.
Modelserver change for reference: eclipse-emfcloud/emfcloud-modelserver#244
Fixes #449.