Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Dosgi.dataAreaRequiresExplicitInit=true doesn't work anymore #21

Closed
iloveeclipse opened this issue Apr 22, 2022 · 5 comments
Closed

-Dosgi.dataAreaRequiresExplicitInit=true doesn't work anymore #21

iloveeclipse opened this issue Apr 22, 2022 · 5 comments
Assignees
@iloveeclipse
Labels
bug Something isn't working regression
Milestone
4.24 M2

Comments

@iloveeclipse
Copy link
Member

iloveeclipse commented Apr 22, 2022 •
edited
Loading

While reviewing eclipse-platform/eclipse.platform.resources#71 I've found, that I'm able to silently init a workspace (with default value) without specifying workspace location explicitly via prompt or -data argument, even if -Dosgi.dataAreaRequiresExplicitInit=true is set in eclipse.ini.

This is a regression, so bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=514333 is back.

I'm investigating where it was broken... 4.19 is OK, 4.20 is broken...

OK, regression is coming from

Ironically, commit message was The start code for the plugin can be migrated to run inside Workspace without changing existing behaviour....
@iloveeclipse iloveeclipse added bug Something isn't working regression labels Apr 22, 2022
@iloveeclipse iloveeclipse self-assigned this Apr 22, 2022
iloveeclipse added a commit to iloveeclipse/java-things that referenced this issue Apr 22, 2022
@iloveeclipse
Bad workspace init bundle example
7e50e68 
Bundle uses immediate service to init workspace to default location,
before prompt is even shown.

See eclipse-equinox/equinox.bundles#21
iloveeclipse added a commit to iloveeclipse/java-things that referenced this issue Apr 22, 2022
@iloveeclipse
Bad workspace init bundle example
55f6834 
Bundle uses immediate service to init workspace to default location,
before prompt is even shown.

See eclipse-equinox/equinox.bundles#21
@tjwatson
Copy link
Contributor

It seems we don't have tests for this?

@iloveeclipse
Copy link
Member Author

Yes, we don't have tests. If you have a pointer how a test could be added that tests Eclipse startup with some custom launch arguments and checks something from inside that Eclipse, I could add one.

@tjwatson
Copy link
Contributor

Yes, we don't have tests. If you have a pointer how a test could be added that tests Eclipse startup with some custom launch arguments and checks something from inside that Eclipse, I could add one.

There is something called session tests that can be run. It is not the most elegant way of testing but it can be done. Here is one of the more "simple" testcases I found that uses it where the testcase is setting some specific values in a config.ini: org.eclipse.osgi.tests.configuration.EclipseStarterConfigIniTest

@iloveeclipse
Copy link
Member Author

OK, I have a fix but that is in resources, so I will close this issue and reopen one in platform resources.

@iloveeclipse iloveeclipse mentioned this issue Apr 22, 2022
Closed
@iloveeclipse
Copy link
Member Author

Proposed fix: eclipse-platform/eclipse.platform.runtime#36

@HannesWell HannesWell added this to the 4.24 M2 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
bug Something isn't working regression
Projects
None yet
Milestone
4.24 M2
Development

No branches or pull requests
3 participants
@tjwatson @iloveeclipse @HannesWell