-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Linux on riscv64 #669
Add support for Linux on riscv64 #669
Conversation
It can be built on riscv64 hardware with |
But If I use |
bundles/org.eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/processor.aliases
Outdated
Show resolved
Hide resolved
e430715
to
09f8d33
Compare
I'll try to have a detailed look at this tomorrow, but from a very quick view I see that the adjustment of the Jenkins file is missing. In general the same like in #559 should be done. |
09f8d33
to
c768516
Compare
Thanks. I made one change and let us to see. FYI, ci.eclipse.org/releng has riscv64 hardware |
Finally I understood what mean of It sees we can use Temurin openJdk first to build native binaries for riscv64. |
c768516
to
e4836fb
Compare
I have added support riscv64 in Jenkinsfile. but it does not affect the riscv64 from build log: [Pipeline] { (Build launcher and executable native binaries)
[Pipeline] parallel
[Pipeline] { (Branch: Matrix - PLATFORM = 'cocoa.macosx.aarch64')
[Pipeline] { (Branch: Matrix - PLATFORM = 'cocoa.macosx.x86_64')
[Pipeline] { (Branch: Matrix - PLATFORM = 'gtk.linux.aarch64')
[Pipeline] { (Branch: Matrix - PLATFORM = 'gtk.linux.ppc64le')
[Pipeline] { (Branch: Matrix - PLATFORM = 'gtk.linux.x86_64')
[Pipeline] { (Branch: Matrix - PLATFORM = 'win32.win32.aarch64')
[Pipeline] { (Branch: Matrix - PLATFORM = 'win32.win32.x86_64') I suspect we must added |
e4836fb
to
27fdff1
Compare
I am stuck in here, could you help me to have a look at this? TIA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we must added
Branch: Matrix - PLATFORM = 'gtk.linux.riscv64'
at Jenkins backends.I am stuck in here, could you help me to have a look at this? TIA
That's right. Since you are not a committer on this Jenkins does not consider your changes to the pipeline file.
But I just applied them in a Replay:
https://ci.eclipse.org/releng/job/equinox/job/PR-669/8/
The build now starts but fails with:
+ sh build.sh -ws gtk -os linux -arch riscv64 install
build.sh: 161: make: not found
I think we have to ask the infrastructure team to install make
on the riscv machine.
Please move all the version bumps into a separate commit with message:
Version bumps for 4.34 stream
This way they can be identified in the history more easily.
bundles/org.eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/processor.aliases
Outdated
Show resolved
Hide resolved
9583ff6
to
be2c91e
Compare
Rebased on be2c91e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on be2c91e
Great. Thanks!
Btw. have you see my comment from the other thread?
#669 (comment)
This should solve the resolution error.
With that and once all the necessary tools in the agent are installed, I think this should be ready.
And regarding your second PR #672:
Thanks for that, but it would be fine if you add that separate commit as second commit in this PR. A separate PR is not necessary for that.
Thanks. I read it again carefully and now I understand what it is.:)
Okay, got it. Iet me try it again. |
a84cdd4
to
92b46d0
Compare
27259ec
to
e28b415
Compare
Rebase on 773fe39. Not sure tests/build ci failure was related with this. |
Thanks. I'll try to have a look at this this evening and all your other PRs, it's just very busy at the moment. Sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "arm" should be in uppercase
bundles/org.eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/processor.aliases
Outdated
Show resolved
Hide resolved
b52e023
to
db66734
Compare
Thank you. No rush.:) |
db66734
to
c3a024e
Compare
c3a024e
to
cf7066f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a few adjustments to your branch, e.g. some version bumps in features are not necessary (anymore) and the version of all Linux fragments should be aligned and a few white-space fixes.
But with this change is now ready for submission.
Thanks for this.
Thank you! \o/. |
This allows to pick-up the new root-files for linux.riscv64 contributed via eclipse-equinox#669
This qualifier-bump ensures that the new root-files for linux.riscv64 are picked up in the I-build with the linux.riscv64 environment enabled. Support for linux.riscv64 was contributed via eclipse-equinox#669
This qualifier-bump ensures that the new root-files for linux.riscv64 are picked up in the I-build with the linux.riscv64 environment enabled. Support for linux.riscv64 was contributed via #669
No description provided.