Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] CLI SAMM2AAS Generator: add samm:description to ConceptDescription IEC61360/definition #434

Closed
BirgitBoss opened this issue Oct 10, 2023 · 2 comments · Fixed by #492
Labels
2023-10-19 acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. task

Comments

@BirgitBoss
Copy link
Contributor

Is your task related to a problem? Please describe.

Instead of writing the samm:definition to Property/description samm:definition shall be mapped to data specification IEC62360 definition, because it belongs to semantics

<dataSpecificationContent> <dataSpecificationIec61360>
...
<definition> <langStringDefinitionTypeIec61360> <language>X-33DQI-g</language> <text>something_2ae95f9f</text> </langStringDefinitionTypeIec61360> </definition>

@chris-volk chris-volk added acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. 2023-10-19 labels Oct 19, 2023
@KobOp
Copy link
Contributor

KobOp commented Nov 23, 2023

@BirgitBoss according to SAMM CLI 2.4.1, the property' samm:description is mapped to aas:property, whereas the dataSpecificationIec61360 contains the property's characteristic description.
E.g.

:speed a samm:Property ;
   samm:preferredName "speed"@en ;
   samm:description "speed of vehicle"@en ;
   samm:characteristic :Speed .
:Speed a samm-c:Measurement ;
   samm:preferredName "speed"@en ;
   samm:description "Scalar representation of speed of an object in kilometers per hour."@en ;
   samm:dataType xsd:float ;
   samm-c:unit unit:kilometrePerHour .

becomes

<aas:property>
  <aas:idShort>id_speed</aas:idShort>
  <aas:displayName>...</aas:displayName>
  <aas:description>
	<aas:langStringTextType>
	  <aas:language>en</aas:language>
	  <aas:text>speed of vehicle</aas:text>
	</aas:langStringTextType>
  </aas:description>
  <aas:semanticId>...</aas:semanticId>
  ...
</aas:property>
...
<aas:conceptDescription> 
  <aas:dataSpecificationIec61360>
    <aas:preferredName>...</aas:preferredName>
    <aas:shortName>...</aas:shortName>
	<aas:unit>kilometrePerHour</aas:unit>
	  <aas:definition>
		<aas:langStringDefinitionTypeIec61360>
		  <aas:language>en</aas:language>
		  <aas:text>Scalar representation of speed of an object in kilometers per hour.</aas:text>
		</aas:langStringDefinitionTypeIec61360>
	  </aas:definition>
  </aas:dataSpecificationIec61360>
</aas:conceptDescription>

To move the property description from aas:property to the aas:dataSpecifiationIed61360, the characteristic description would be lost. @atextor do you have an idea to keep both semantic descriptions?

@BirgitBoss
Copy link
Contributor Author

BirgitBoss commented Nov 23, 2023

I think we should accept that information is lost when converting a SAMM model into an Submodel Template using IEC61360 data specification.

So the complete concept description is representing the characteristic. I.e. if the name would be something generic like speed and the property a preferred name "maximum speed" the preferred name in CD would be "speed" and not "maximum speed"?

We had a lot of discussions about the mapping but my expectation was that the CD represents the samm:property and not the characteristic.

Yauhenikapl added a commit to bci-oss/esmf-sdk that referenced this issue Dec 19, 2023
…iption

Changes:
- Remove description from Property;
- Add Property Description to Definition.

Fixes eclipse-esmf#434
Yauhenikapl added a commit to bci-oss/esmf-sdk that referenced this issue Dec 19, 2023
Yauhenikapl added a commit to bci-oss/esmf-sdk that referenced this issue Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023-10-19 acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants