-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] CLI SAMM2AAS Generator: add samm:description to ConceptDescription IEC61360/definition #434
Comments
@BirgitBoss according to SAMM CLI 2.4.1, the property' samm:description is mapped to aas:property, whereas the dataSpecificationIec61360 contains the property's characteristic description.
becomes
To move the property description from aas:property to the aas:dataSpecifiationIed61360, the characteristic description would be lost. @atextor do you have an idea to keep both semantic descriptions? |
I think we should accept that information is lost when converting a SAMM model into an Submodel Template using IEC61360 data specification. So the complete concept description is representing the characteristic. I.e. if the name would be something generic like speed and the property a preferred name "maximum speed" the preferred name in CD would be "speed" and not "maximum speed"? We had a lot of discussions about the mapping but my expectation was that the CD represents the samm:property and not the characteristic. |
…iption Changes: - Remove description from Property; - Add Property Description to Definition. Fixes eclipse-esmf#434
…iption. Add tests Changes: - Add tests; Fixes eclipse-esmf#434
…iption. Refactoring Changes: - Refactoring Fixes eclipse-esmf#434
Is your task related to a problem? Please describe.
Instead of writing the samm:definition to Property/description samm:definition shall be mapped to data specification IEC62360 definition, because it belongs to semantics
<dataSpecificationContent> <dataSpecificationIec61360>
...
<definition> <langStringDefinitionTypeIec61360> <language>X-33DQI-g</language> <text>something_2ae95f9f</text> </langStringDefinitionTypeIec61360> </definition>
The text was updated successfully, but these errors were encountered: