[BUG] SAMM-CLI aas generation: Mapping of Set Characteristics

[mhmmi]

How: List of performed steps
I modeled the following in SAMM

• SAMM Property "myRoles"
• with SAMM Set Characteristic "RoleSet"
• with SAMM Enum Characteristic "RoleEnum"

and then applied SAMM-CLI to derive an AAS

What: Actual result vs expected result
SAMM CLI currently maps this to an AAS SubmodelElementList (SML) plus AAS Property elements inside. Good. Yet, the SML has no semanticId while the AAS properties inside use the id of the SAMM property. Furthermore, both use the same idShort.

IMHO I'd expect the following outcome

• AAS SubmodelElementList (SML) with idShort "myRoles" and semanticId ...
  • my suggestion: "urn:samm:com.example.roles:0.0.1#myRoles"
• IMHO the AAS SML directly represents the SAMM Property
• with many child AAS Properties with empty(*) idShort and each with the same semanticId ...
  • my suggestion 1: "urn:samm:com.example.roles:0.0.1#RoleEnum" (i.e. the Set characteristic's element characteristic)
  • my suggestion 2: or sth. like "urn:samm:com.example.roles:0.0.1#myRoles.element"

(*) "Constraint AASd-120: idShort of submodel elements being a direct child of a SubmodelElementList shall not be specified."

Where: (e.g. component, version, url, your system info)

Input (files/screenshots)

Output (files/screenshots)

Additional context (e.g. references)

[chris-volk]

Thanks very much for your input, we will look into the details how we can improve the mapping.

[BirgitBoss]

your point "the SML has no semanticId" is reflected in
#522 add semanticId to all elements

[BirgitBoss]

may you please provide your .ttl file and the generated aasx file? It is not completely clear to me how you modelled it. Is it

:Aspect3 a samm:Aspect ;
   samm:properties ( :myRoles ) ;
   samm:operations ( ) ;
   samm:events ( ) .

:myRoles a samm:Property ;
   samm:characteristic :RoleSet .


:RoleSet a samm-c:Enumeration ;
   samm-c:values ( "role2" "role1" ) .

or

:Aspect3 a samm:Aspect ;
   samm:properties ( :myRoles ) ;
   samm:operations ( ) ;
   samm:events ( ) .

:myRoles a samm:Property ;
   samm:characteristic :RoleSet .

:RoleSet a samm-c:Set ;
   samm:dataType :Roles .

:Roles a samm:Entity ;
   samm:properties ( :role ) .

:role a samm:Property ;
   samm:characteristic :MyRolesEnum .

:RolesEnum a samm-c:Enumeration ;
   samm-c:values ( "role 2" "role1" ) .

[github-actions]

Release v2.9.6 addresses this.