-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Aspect Model Diagram generation #407
Improve Aspect Model Diagram generation #407
Conversation
7825554
to
7a8241f
Compare
@RaMisess what is the status with this PR? Will the conflict be resolved soon? |
@atextor @RaMisess what is the status of this PR? The graphiz library causes some class path issues in our semantic hub implementation, which we hope to get resolved by this PR. A new Release with this PR would be greatly appreciated. |
The status of the PR is that is actively being worked on. While the core changes in the SDK are already implemented and tested, the native image build of samm-cli is currently failing: Font handling code in the JDK itself fails due to hardcoded checks for JRE availability at runtime etc.. This is being addressed with corresponding substitution classes. |
Since the fat jar already contains everything, there is no need to scan the complete class path again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Release v2.4.0 addresses this. |
Fixes #406. This implements a new diagram generator that is not any longer based
on executing multiple SPARQL queries, but rather implements an
AspectModelVisitor that emits an abstract diagram representation (boxes and
edges) which is fed into the graph-support library to generate SVG from it. PNG
is created by creating SVG, then calling Apache Batik.
The dependency to graphviz-java is removed.