Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Aspect Model Diagram generation #407

Merged
merged 39 commits into from
Oct 11, 2023

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Aug 4, 2023

Fixes #406. This implements a new diagram generator that is not any longer based
on executing multiple SPARQL queries, but rather implements an
AspectModelVisitor that emits an abstract diagram representation (boxes and
edges) which is fed into the graph-support library to generate SVG from it. PNG
is created by creating SVG, then calling Apache Batik.
The dependency to graphviz-java is removed.

@atextor atextor requested a review from michelu89 August 4, 2023 08:44
@atextor atextor force-pushed the 406-improve-diagram-generation branch from 7825554 to 7a8241f Compare August 4, 2023 09:05
@bs-jokri
Copy link
Contributor

bs-jokri commented Sep 7, 2023

@RaMisess what is the status with this PR? Will the conflict be resolved soon?

@bs-jokri
Copy link
Contributor

@atextor @RaMisess what is the status of this PR? The graphiz library causes some class path issues in our semantic hub implementation, which we hope to get resolved by this PR. A new Release with this PR would be greatly appreciated.
https://github.com/eclipse-tractusx/sldt-semantic-hub

@atextor
Copy link
Contributor Author

atextor commented Sep 26, 2023

@atextor @RaMisess what is the status of this PR? The graphiz library causes some class path issues in our semantic hub implementation, which we hope to get resolved by this PR. A new Release with this PR would be greatly appreciated. https://github.com/eclipse-tractusx/sldt-semantic-hub

The status of the PR is that is actively being worked on. While the core changes in the SDK are already implemented and tested, the native image build of samm-cli is currently failing: Font handling code in the JDK itself fails due to hardcoded checks for JRE availability at runtime etc.. This is being addressed with corresponding substitution classes.

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@atextor atextor merged commit 2599683 into eclipse-esmf:main Oct 11, 2023
3 checks passed
@atextor atextor deleted the 406-improve-diagram-generation branch October 11, 2023 12:16
@github-actions
Copy link

Release v2.4.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Improve diagram generation
4 participants