Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate UTF-8 encoded diagrams regardless of platform encoding #507

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Generate UTF-8 encoded diagrams regardless of platform encoding #507

merged 1 commit into from
Jan 19, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Jan 19, 2024

Fixes #487

Yauhenikapl
Yauhenikapl approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@atextor atextor merged commit 679fdd2 into eclipse-esmf:main Jan 19, 2024
3 checks passed
@atextor atextor deleted the 487-wrong-encoding-in-diagrams branch January 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yauhenikapl Yauhenikapl Yauhenikapl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SVG Diagram generation fails to provide a "displayable" UTF-8 encoding string
2 participants
@atextor @Yauhenikapl