Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting Aspect to JSON-LD #651

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Converting Aspect to JSON-LD #651

merged 10 commits into from
Sep 12, 2024

Conversation

Yauhenikapl
Copy link
Contributor

@Yauhenikapl Yauhenikapl commented Sep 4, 2024 •
edited
Loading

Description

Representation Aspect to JSON-LD

Fixes #644

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes

@Yauhenikapl Yauhenikapl marked this pull request as ready for review September 10, 2024 09:25
@Yauhenikapl Yauhenikapl changed the title Test Converting Aspect to JSON-LD Converting Aspect to JSON-LD Sep 11, 2024
atextor
atextor requested changes Sep 11, 2024
View reviewed changes
.../test/java/org/eclipse/esmf/aspectmodel/generator/jsonld/AspectModelJsonLdGeneratorTest.java Outdated Show resolved Hide resolved
.../test/java/org/eclipse/esmf/aspectmodel/generator/jsonld/AspectModelJsonLdGeneratorTest.java Outdated Show resolved Hide resolved
documentation/developer-guide/modules/tooling-guide/pages/maven-plugin.adoc Outdated Show resolved Hide resolved
documentation/developer-guide/modules/tooling-guide/pages/maven-plugin.adoc Outdated Show resolved Hide resolved
documentation/developer-guide/modules/tooling-guide/pages/samm-cli.adoc Outdated Show resolved Hide resolved
...smf-aspect-model-maven-plugin/src/main/java/org/eclipse/esmf/aspectmodel/GenerateJsonLd.java Outdated Show resolved Hide resolved
tools/samm-cli/src/main/java/org/eclipse/esmf/aspect/to/AspectToJsonLdCommand.java Outdated Show resolved Hide resolved
@Yauhenikapl Yauhenikapl force-pushed the 644-represent-aspect-model-in-json-ld branch from f1ef4ba to e75ea3c Compare September 11, 2024 12:56
@Yauhenikapl Yauhenikapl merged commit 255fe98 into eclipse-esmf:main Sep 12, 2024
4 checks passed
@Yauhenikapl Yauhenikapl deleted the 644-represent-aspect-model-in-json-ld branch September 12, 2024 00:38
@github-actions GitHub Actions
Copy link

Release v2.9.6 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atextor atextor atextor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Represent Aspect Model in JSON-LD
2 participants
@Yauhenikapl @atextor