Merge org.eclipse.jdt.apt.core into org.eclipse.jdt.core #2548
+1,072
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation notes: * org.eclipse.jdt.apt.core "proxies" to org.eclipse.jdt.core * Both new and legacy extension points ids are processed, this brings backward compatibility * Platform mandates that we change the marker ids * The marker type constants had to move so that client code reacts to their value changing
I don't think JDT needs backward compatibility. All jdt plugins are released simultaneously and won't work together with versions of another release. |
|
What I had in mind was more backward compatibility for 3rd party consumer of the extension point and APIs. Those should still work without issue with previous or newer version, pre or post refactoring. |
|
I'm putting it on hold for the moment; I still think it's a good change and we may need it later, so I'm not closing. But I'm fine with even delaying it after next release. |
|
Let's convert it to draft so it gets clearer that we don't need review at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2581
Implementation notes:
What it does
How to test
Author checklist