-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23] FoldingStructureComputationContext should respect the project compliance level for parsing #1635
[23] FoldingStructureComputationContext should respect the project compliance level for parsing #1635
Conversation
compliance level for parsing fixes eclipse-jdt#1634
I admit I didn't fully explore the the interactions between |
baf47a1
to
ef454c9
Compare
ef454c9
to
fc808ab
Compare
@iloveeclipse @jjohnstn @jarthana I could use some help getting a build without complaints on "new warnings" in files I haven't touched. I guess some merge from master must have stirred up some dust ... already needing to bump up versions in lots of plug-ins just in this PR was unexpected. Also the need to update MarkdownCommentsTest should have been caught earlier (was caused by a change in JDT/Core from 5 Sept). The clock is ticking for Java 23 ... |
I don't understand how changes from master (post release) can have an impact here. I see that we are using the Y build as eclipse-p2-repo.url in the POM file. |
New error:
The build pulls artifacts from
|
I assume that this was a bug introduced in the context of releasing 4.33 and preparing for 4.34. For now I'm trying to bypass the broken redirect by directly referring to https://download.eclipse.org/eclipse/updates/4.33-Y-builds |
9eeb171
into
eclipse-jdt:BETA_JAVA23
I chose to ignore existing warnings, because
|
Since https://bugs.eclipse.org/73400 folding tries to use a shared scanner (for performance reasons). But that shared scanner may be inappropriately configured.
To minimize interference with https://bugs.eclipse.org/73400 I created a separate field
FoldingStructureComputationContext.fScannerForProject
which is used if a difference between project compliance and workspace defaults is detected.fixes #1634