Renaming the methods arguments

Signed-off-by: sheche <[email protected]>
eclipse-jdtls · Jun 20, 2022 · eb8f148 · eb8f148
1 parent c26d07a
commit eb8f148
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/...core/src/org/eclipse/jdt/ls/core/internal/handlers/ProjectConfigurationUpdateHandler.java b/...core/src/org/eclipse/jdt/ls/core/internal/handlers/ProjectConfigurationUpdateHandler.java
@@ -38,9 +38,15 @@ public ProjectConfigurationUpdateHandler(ProjectsManager projectManager) {
 		this.projectManager = projectManager;
 	}
 
-	public void updateConfigurations(List<TextDocumentIdentifier> param) {
+	/**
+	 * Update the projects' configurations (build files).
+	 *
+	 * @param identifiers the identifiers which may point to the projects' paths or
+	 * files that belong to some projects in the workspace.
+	 */
+	public void updateConfigurations(List<TextDocumentIdentifier> identifiers) {
 		Set<IProject> projects = new HashSet<>();
-		for (TextDocumentIdentifier identifier : param) {
+		for (TextDocumentIdentifier identifier : identifiers) {
 			IProject project = getProjectFromUri(identifier.getUri());
 			if (project != null) {
 				projects.add(project);

diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/lsp/JavaProtocolExtensions.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/lsp/JavaProtocolExtensions.java
@@ -62,6 +62,8 @@ public interface JavaProtocolExtensions {
 
 	/**
 	 * Request a project configuration update
+	 *
+	 * @deprecated Please use {@link #projectConfigurationsUpdate(TextDocumentIdentifier)}.
 	 * @param documentUri the document from which the project configuration will be updated
 	 */
 	@JsonNotification
@@ -72,7 +74,7 @@ public interface JavaProtocolExtensions {
 	 * @param documentUris the documents from which the project configuration will be updated
 	 */
 	@JsonNotification
-	void projectConfigurationsUpdate(ProjectConfigurationsUpdateParam documentUris);
+	void projectConfigurationsUpdate(ProjectConfigurationsUpdateParam params);
 
 	@JsonRequest
 	CompletableFuture<BuildWorkspaceStatus> buildWorkspace(Either<Boolean, boolean[]> forceReBuild);

diff --git a/.../src/org/eclipse/jdt/ls/core/internal/handlers/ProjectConfigurationUpdateHandlerTest.java b/.../src/org/eclipse/jdt/ls/core/internal/handlers/ProjectConfigurationUpdateHandlerTest.java
@@ -16,7 +16,6 @@
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyBoolean;
 import static org.mockito.ArgumentMatchers.eq;
-import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;