java.project.referencedLibraries should resolve paths leading with ~

[snjeza]

Fixes #1735

• replaces paths leading with ~ with the user.home system property
• replaces ${} with their matching values from the environment variables and system properties
• resolves java.project.referencedLibraries, java.import.gradle.home, java.import.gradle.java.home, java.import.gradle.user.home, java.configuration.maven.userSettings, java.configuration.maven.globalSettings, java.project.outputPath, java.project.sourcePaths, java.format.settings.url, java.settings.url, java.configuration.runtimes

Signed-off-by: Snjezana Peco [email protected]

[rgrunber]

Nice. So we had ResourceUtils#expandPath(..) all along but just working on the maven user/global settings. I think this is a nice improvement. Technically users can have file/folders like ${foo} (at least on Linux). Does this still allow such a file/folder to be used assuming the user hasn't defined ${foo} in system properties/env ?

[snjeza]

Technically users can have file/folders like ${foo} (at least on Linux). Does this still allow such a file/folder to be used assuming the user hasn't defined ${foo} in system properties/env ?

see 199653e#diff-8699e13c637b9d38b7ec8c77ffc66ecd9443e94dde8d57347fdea1115560631fR266

[snjeza]

So we had ResourceUtils#expandPath(..) all along but just working on the maven user/global settings

Before, ResourceUtils#expandPath(..) was just replacing leading ~.

[rgrunber]

Overall, looks good to me. @fbricon let me know your thoughts. Only thing I can think of that really isn't our issue, is if a user of some client becomes confused by the fact that the client itself doesn't support such a feature. Then again, we already supported '~' . We didn't really document this on the server side, so it's up to clients to decide whether they want to mention this ability.

[rgrunber]

test this please
(didn't see the failure locally)

[rgrunber]

I would modify the commit to include the things in your main PR comment. From what I can see, the commit only has the title, but no reference to the issue, or the additional enhancements listed in #1739 (comment) .

[rgrunber]

test this please
(different failure, still seems unrelated)

[snjeza]

I would modify the commit to include the things in your main PR comment. From what I can see, the commit only has the title, but no reference to the issue, or the additional enhancements listed in #1739 (comment) .

Fixed.

[snjeza]

test this please

[rgrunber]

test this please

[rgrunber]

@snjeza can you just wrap each line of the commit message body to <= 72 characters, and then I think we can merge.

[snjeza]

@snjeza can you just wrap each line of the commit message body to <= 72 characters, and then I think we can merge.

Done.