Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add *.gradle.kts support #1849

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Add *.gradle.kts support #1849

merged 2 commits into from
Aug 25, 2021

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Aug 20, 2021 •
edited
Loading

fbricon and others added 2 commits August 20, 2021 02:16
@snjeza snjeza mentioned this pull request Aug 20, 2021
Merged
@rgrunber
Copy link
Contributor

Seems to be working for me. Project classpath seems accessible for the most part.

  • Importing a basic project doesn't cause the .kt files to be compiled to .class files, but running gradle build from commandline does
  • Is it possible to get the generated kotlin class files onto the classpath so they can be referenced within Java code ?

@snjeza
Copy link
Contributor Author

snjeza commented Aug 25, 2021 •
edited
Loading

  • Importing a basic project doesn't cause the .kt files to be compiled to .class files, but running gradle build from commandline does
  • Is it possible to get the generated kotlin class files onto the classpath so they can be referenced within Java code ?

I will try to solve it within #449.
This ticket enables import gradle projects which use the Gradle Kotlin DSL scripts (*.gradle.kts).

rgrunber
rgrunber approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I would just squash the 2 commits here before merging.

@snjeza snjeza merged commit 05b938f into eclipse-jdtls:master Aug 25, 2021
@fbricon fbricon mentioned this pull request Sep 9, 2021
Closed
@daplf daplf mentioned this pull request Apr 7, 2023
Open
@MadoScientist97 MadoScientist97 mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@liuchong liuchong liuchong approved these changes

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Gradle .kts Files
4 participants
@snjeza @rgrunber @liuchong @fbricon