Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support completion insert replace capability #2057

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Support completion insert replace capability #2057

merged 1 commit into from
Apr 26, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Apr 14, 2022 •
edited
Loading

requires redhat-developer/vscode-java#2427

Signed-off-by: sheche [email protected]

@jdneo jdneo marked this pull request as ready for review April 22, 2022 08:40
@jdneo jdneo changed the title [WIP] Support completion insert replace capability Support completion insert replace capability Apr 22, 2022
@jdneo jdneo requested a review from rgrunber April 22, 2022 08:40
@jdneo
Copy link
Contributor Author

jdneo commented Apr 22, 2022

IntelliCode just released. We can re-enable this feature now. :)

@jdneo jdneo mentioned this pull request Apr 22, 2022
Merged
rgrunber
rgrunber approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same as previous PR. I guess "equals(" is more resilient than equals(${1:arg0}) ?

@jdneo jdneo merged commit 466c626 into eclipse-jdtls:master Apr 26, 2022
@jdneo jdneo deleted the completion-insert-replace branch April 26, 2022 01:03
@rgrunber rgrunber added this to the Early May 2022 milestone May 4, 2022
@jdneo jdneo mentioned this pull request May 24, 2022
Closed
@jdneo jdneo mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Early May 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@jdneo @rgrunber