Update target platform to 4.25-I-builds

[snjeza]

Fixes #2127

Signed-off-by: Snjezana Peco [email protected]

[jdneo]

Not sure if it is the issue with my local environment. After updating the target platform, I cannot launch the JDT.LS using PDE. With a lot of Unresolved requirement... printed in the terminal.

// cc @testforstephen

[snjeza]

@jdneo I can't reproduce the issue. Could you try to clean your workspace?

[jdneo]

Still not working after cleaning workspace cache. BTW, I'm using PDE in VS Code and launch from the file jdt.ls.socket-stream.launch, I haven't tried Eclipse yet.

[snjeza]

I have created a vsix.

[jdneo]

Have no idea why, but so far both @CsCherrYY and me encountered the same problem. 🤔 Will take a look and update here if we find anything.

[testforstephen]

I'm also facing issues when using vscode-pde to launch JLS from jdt.ls.socket-stream.launch. Let's debug to see what happens.

[testforstephen]

Adding the following bundles to the dependencies list of jdt.ls.socket-stream.launch, the launching works again. Will create a PR to fix this.

<setEntry value="org.osgi.service.prefs@default:default"/>
<setEntry value="org.osgi.util.function@default:default"/>
<setEntry value="org.osgi.util.measurement@default:default"/>
<setEntry value="org.osgi.util.position@default:default"/>
<setEntry value="org.osgi.util.promise@default:default"/>
<setEntry value="org.osgi.util.xml@default:default"/>

[snjeza]

@testforstephen You could create a separate launch configuration.

[rgrunber]

I was able to reproduce in Eclipse once I cleaned my target platform. I only needed :

<setEntry value="org.osgi.service.prefs@default:default"/>
<setEntry value="org.osgi.util.function@default:default"/>
<setEntry value="org.osgi.util.promise@default:default"/>

which is also confirmed by doing a build of the language product.

Also, looks like org.eclipse.osgi.util is no longer part of the product.

[testforstephen]

I was able to reproduce in Eclipse once I cleaned my target platform. I only needed :

<setEntry value="org.osgi.service.prefs@default:default"/>
<setEntry value="org.osgi.util.function@default:default"/>
<setEntry value="org.osgi.util.promise@default:default"/>

which is also confirmed by doing a build of the language product.

Also, looks like org.eclipse.osgi.util is no longer part of the product.

Yes, only these three bundles are necessary.

[jdneo]

Just FYI, after adopting new target platform, we can now have more concrete type candidate when completion for an interface:

completion.mp4

[rgrunber]

Nice :) ( eclipse-jdt/eclipse.jdt.core#15 )