Add buildship auto sync preference

[snjeza]

Fixes redhat-developer/vscode-java#2673

Signed-off-by: Snjezana Peco [email protected]

[CsCherrYY]

I'm curious what's the difference between this one and the currrent configuraiton java.configuration.updateBuildConfiguration for Gradle projects, will they do the similar thing?

[testforstephen]

I'm curious what's the difference between this one and the currrent configuraiton java.configuration.updateBuildConfiguration for Gradle projects, will they do the similar thing?

+1

[snjeza]

I'm curious what's the difference between this one and the currrent configuraiton java.configuration.updateBuildConfiguration for Gradle projects, will they do the similar thing?

You are right. They do the similar thing. See redhat-developer/vscode-java#2673 (comment)
We could still add this property if a user moves a project from Eclipse with auto.sync=true. VS Code shouldn't update org.eclipse.buildship.core.prefs

[CsCherrYY]

Get it. My point is if we can just use the value of java.configuration.updateBuildConfiguration to set auto.sync of buildship configuration (if it works)? In this way we can avoid adding a new VS Code configuration and making users confused due to multiple "sync" configurations.

[snjeza]

My point is if we can just use the value of java.configuration.updateBuildConfiguration to set auto.sync of buildship configuration (if it works)?

We can set auto.sync to true if java.configuration.updateBuildConfiguration = automtatic

[CsCherrYY]

We can set auto.sync to true if java.configuration.updateBuildConfiguration = automtatic

Sounds great. In this way, if a user set java.configuration.updateBuildConfiguration to automatic and we also set auto.sync to true, will the buildship synchorize the project twice? (the first one comes from auto.sync and the second one from language server) Or jdtls/buildhsip side has some mechanisms to prevent this?

[snjeza]

will the buildship synchorize the project twice? (the first one comes from auto.sync and the second one from language server) Or jdtls/buildhsip side has some mechanisms to prevent this?

I will check.
I have fixed it. See 6474013#diff-f23d0258ce24117c110acd6753e8490a09fbdf0bc039d662bdffe279c8c28469R242

[CsCherrYY]

LGTM