Fix bad .git resourceFilter #2251
Conversation
|
re-test this please. |
|
The default value for the client settings 'java.project.resourceFilters' needs to be updated as well. |
|
re-test this please. |
There was a problem hiding this comment.
Ok there's a small bug here slightly related.
https://github.com/eclipse/eclipse.jdt.ls/blob/d65385a0d09df1c3a904a6644efe1b0c1a7860d0/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L1042 never passes in the language server default value, so if the client doesn't set it, it doesn't fall back to https://github.com/eclipse/eclipse.jdt.ls/blob/d65385a0d09df1c3a904a6644efe1b0c1a7860d0/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L628 . Just need to pass that value as the 3rd argument to getList(..)
Fixes eclipse-jdtls#2244 Signed-off-by: Fred Bricon <[email protected]>
Signed-off-by: Fred Bricon <[email protected]>
done |
Fix bad .git resourceFilter (fixes #2244)
also fixes wrong jdt compiler settings (don't squash commits)