Do not mandate LanguageServerApplication running #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rgrunber
reviewed
Nov 14, 2022
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseInitHandler.java
Outdated
Show resolved
Hide resolved
mickaelistria
force-pushed
the
processId-2311
branch
from
e7fc9a8
to
63c4213
Compare
Remove an execution path that only works if IApplication is running; so JDT-LS can be used in different deployments. Part of eclipse-jdtls#2311
rgrunber
force-pushed
the
processId-2311
branch
from
63c4213
to
11d9eca
Compare
rgrunber
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an execution path that only works if IApplication is running; so JDT-LS can be used in different deployments.
Part of #2311