-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python wrapper for Windows #2808
Conversation
Can one of the admins verify this patch? |
Maybe change it to |
Yes, putting it in the scripts directory would copy it to the final destination.
It would probably need to be |
Ok done, I don't have an eclipse account though. If there's a problem with that, somebody can just close this PR and create a new one. |
I can take a look at this some time today, just setting up Helix on my Windows box... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I added eclipse.jdt.ls\org.eclipse.jdt.ls.product\target\repository\bin
to PATH, and I can get validation and go-to-definition in Helix.
Going by https://www.eclipse.org/projects/handbook/#contributing-eca maybe we can avoid re-creating this PR by just confirming what signing the ECA implies.
|
Yes it has been written by me.
Yes
Sure no problem. |
Hi, after adding jdtls bin to PATH variable on windows you can't run the lsp server because they are python scripts. I know you can use the java command but then you would need to use a different command for Linux and Windows and it requires you to set the options manually.
Adding a simple batch file to the bin directory allows it to be run from path on Windows with just "jdtls". I think putting it in scripts directory would copy it there? Didn't build it myself.
This change is important for editors, particularly for https://github.com/helix-editor/helix/blob/master/languages.toml#L36 to be able to work out of the box.
Discussion about this here helix-editor/helix#5861.